Fix lowercase db or schema in connection string #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
sfc-gh-mhofman
requested changes
Mar 1, 2024
| @@ -129,6 +129,11 @@ internal Uri BuildLoginUrl() | |||
| return loginUrl; | |||
| } | |||
|
|
|||
| private string EscapeDbObjectForUrl(string name) | |||
| { | |||
| return name == string.Empty ? name : $"\"{name.Replace("\"", "\"\"")}\""; | |||
There was a problem hiding this comment.
Please make sure the name isn't already wrapped with quotes.
Make sure if connection tests are passing after this fix.
| @@ -119,8 +119,8 @@ internal Uri BuildLoginUrl() | |||
| string schemaValue; | |||
| string roleName; | |||
| queryParams[RestParams.SF_QUERY_WAREHOUSE] = properties.TryGetValue(SFSessionProperty.WAREHOUSE, out warehouseValue) ? warehouseValue : ""; | |||
| queryParams[RestParams.SF_QUERY_DB] = properties.TryGetValue(SFSessionProperty.DB, out dbValue) ? dbValue : ""; | |||
| queryParams[RestParams.SF_QUERY_SCHEMA] = properties.TryGetValue(SFSessionProperty.SCHEMA, out schemaValue) ? schemaValue : ""; | |||
| queryParams[RestParams.SF_QUERY_DB] = EscapeDbObjectForUrl(properties.TryGetValue(SFSessionProperty.DB, out dbValue) ? dbValue : ""); | |||
There was a problem hiding this comment.
Can you provide some unit tests for this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's a bug, that having specified database or schema name in connection string, that contains any lowercase letter, throws exception during connection opening.
This PR fixes that.
Checklist
dotnet test)