Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-878067: Fix retry logic #866

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sfc-gh-ext-simba-lf
Copy link
Collaborator

@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf commented Feb 15, 2024

Description

  1. Add extra check for retry timeout being infinite
  2. Check maxHttpRetries before creating the HttpClient

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf marked this pull request as ready for review February 15, 2024 18:33
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf requested a review from a team as a code owner February 15, 2024 18:33
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.11%. Comparing base (9d61e81) to head (c10d13f).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #866      +/-   ##
==========================================
- Coverage   84.35%   84.11%   -0.24%     
==========================================
  Files          88       88              
  Lines        9336     9401      +65     
  Branches      874      885      +11     
==========================================
+ Hits         7875     7908      +33     
- Misses       1235     1260      +25     
- Partials      226      233       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf changed the title SNOW-878067: Add extra check for retry timeout being infinite SNOW-878067: Fix retry logic Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant