Update README.md (small typos) #910
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
sfc-gh-mhofman
requested changes
Apr 8, 2024
| @@ -274,7 +274,7 @@ If you are using a different method for authentication, see the examples below: | |||
|
|
|||
| where: | |||
|
|
|||
| - `{pathToThePrivateKeyFile}` is the path to the file containing the unencrypted private key. | |||
| - `{pathToThePrivateKeyFile}` is the path to the file containing the encrypted private key. | |||
There was a problem hiding this comment.
There is below an example showing it is not encrypted.
There was a problem hiding this comment.
Hmm. I'm not sure what example you mean.
The section just below this line does use an unencrypted key, but this line seems to be about the example just above ("Specify the file containing an encrypted private key").
Also, why would you need to also provide the private_key_pwd if the private key were not encrypted?
Let me know if I'm missing something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed two typos in the README.