SNOW-1296059: Exclude cloud providers from driver, only required for compile #929
+232
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jmartinezramirez
force-pushed
the
SNOW-1296059-split-dependencies-projects
branch
from
b0470f6 to
c4c7671
Compare
sfc-gh-jmartinezramirez
changed the title
There was a problem hiding this comment.
This looks promising @sfc-gh-sthyagaraj
We end up with
- current thick library: Snowflake.Data (with GCP,AZURE and AWS out-of-the-box)
- thin library: Snowflake.Data.Common (yet my suggestion would be to think and maybe change to e.g. Snowflake.Data.Core)
- cloud specific extensions up to customer needs:
- Snowflake.Data.AWS
- Snowflake.Data.Azure
- Snowflake.Data.GCP
6 tasks
sfc-gh-jmartinezramirez
force-pushed
the
SNOW-1296059-split-dependencies-projects
branch
2 times, most recently
from
e42b6da to
d69439e
Compare
sfc-gh-knozderko
requested changes
Apr 29, 2024
sfc-gh-jmartinezramirez
force-pushed
the
SNOW-1296059-split-dependencies-projects
branch
from
d69439e to
e982a9c
Compare
sfc-gh-jmartinezramirez
force-pushed
the
SNOW-1296059-split-dependencies-projects
branch
from
4c65337 to
faa7b08
Compare
sfc-gh-jmartinezramirez
force-pushed
the
SNOW-1296059-split-dependencies-projects
branch
from
faa7b08 to
c3fd530
Compare
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
sfc-gh-jmartinezramirez
force-pushed
the
SNOW-1296059-split-dependencies-projects
branch
from
c3fd530 to
4c38ae9
Compare
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Azure.Storage.Blobs" Version="12.13.0" /> |
There was a problem hiding this comment.
what about Azure.Storage.Common?
There was a problem hiding this comment.
Added explicit dependency.
| <ExcludeAssets>Runtime,Build,Native,Analyzers,BuildTransitive</ExcludeAssets> | ||
| <IncludeAssets>compile</IncludeAssets> | ||
| </PackageReference> | ||
| <PackageReference Include="Azure.Storage.Blobs" Version="12.13.0" > |
There was a problem hiding this comment.
what about Azure.Storage.Common?
There was a problem hiding this comment.
Added explicit dependency.
Move logic to Snowflake.Data.Core to only have compile dependencies to cloud providers. Add projects for dependencies nuget generation for each cloud provider. Update deploy bat to include new packages
Set alpha version to projects 4.0.1-alpha01. Removed not required set of version, it is calculated base on the Version property.
sfc-gh-jmartinezramirez
force-pushed
the
SNOW-1296059-split-dependencies-projects
branch
from
4a640f0 to
929507d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exclude cloud providers from driver, only required for compile
Move logic to Snowflake.Data.Core to only have compile dependencies to cloud providers.
Add projects for dependencies nuget generation for each cloud provider.
Checklist
dotnet test)