-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1333163 support for default proxy #997
base: master
Are you sure you want to change the base?
Conversation
I have read the CLA Document and I hereby sign the CLA 1 out of 2 committers have signed the CLA. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #997 +/- ##
==========================================
+ Coverage 85.55% 85.67% +0.12%
==========================================
Files 106 106
Lines 10777 10809 +32
Branches 1032 1037 +5
==========================================
+ Hits 9220 9261 +41
+ Misses 1307 1299 -8
+ Partials 250 249 -1 ☔ View full report in Codecov by Sentry. |
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
SNOW-1333163 Add support for default proxy.
When specifying
allowEmptyProxy=true
anduseProxy=true
but without specifying the value ofproxyHost
, the proxy would be enabled but not configured allowing to use a default proxy provided by the operating system.Checklist
dotnet test
)