Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1562336 Add tests for multi statement queries #998

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

SNOW-1562336 Add tests for multi statement queries #998

wants to merge 4 commits into from
+110 −0

Conversation

sfc-gh-jsieminska
Copy link
Collaborator

Description

SNOW-1562336 Add tests for multi statement queries

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@codecov Codecov
Copy link

codecov bot commented Jul 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.63%. Comparing base (982a1e4) to head (84b3c47).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #998      +/-   ##
==========================================
+ Coverage   85.55%   85.63%   +0.08%     
==========================================
  Files         106      106              
  Lines       10777    10777              
  Branches     1032     1032              
==========================================
+ Hits         9220     9229       +9     
+ Misses       1307     1299       -8     
+ Partials      250      249       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-jsieminska
Update SFMultiStatementsIT.cs
84b3c47 
Public schema isn't default in SF
@sfc-gh-jsieminska sfc-gh-jsieminska marked this pull request as ready for review August 5, 2024 07:24
@sfc-gh-jsieminska sfc-gh-jsieminska requested a review from a team as a code owner August 5, 2024 07:24
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2024
sfc-gh-jmartinezramirez
sfc-gh-jmartinezramirez approved these changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dstempniak sfc-gh-dstempniak sfc-gh-dstempniak approved these changes

@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-jsieminska @sfc-gh-jmartinezramirez @sfc-gh-dstempniak