Move aws-sdk to peerDependencies #288
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-sdk is now a peer dependency. Users of this library's S3 functionality will now have to install a compatible version of aws-sdk alongside it. As such, you could argue this is a breaking change. Fixes #216.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
would possibly also fix #449 |
|
This PR will need some code changes, too. Not working yet, IIRC. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aws-sdk is now a peer dependency. Users of this library's S3 functionality will now have to install a compatible version of aws-sdk alongside it. As such, you could argue this is a breaking change.
I haven't tried running the tests yet, and so it may be that aws-sdk should also be listed as a dev dependency, if it is used there.
Fixes #216.