Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding changes to include privatelink in hostname from account #1981

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vinodseshadri
Copy link

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
    SNOW-1507358: OSCP validation fails if hostname is not provided  #1980
    Fixes SNOW-1507358: OSCP validation fails if hostname is not provided  #1980

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

This adds 'privatelink' in hostname if 'private link' is present in account name. This helps to properly set the host name.

Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@vinodseshadri
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-dszmolka
Copy link
Contributor

i suggest we hold with this PR for now until the underlying issue is fully clarified and root caused

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNOW-1507358: OSCP validation fails if hostname is not provided
2 participants