SNOW-1798694: Improve SDK local setup documentation to enable logging #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sfc-gh-tzhang
commented
Jan 24, 2025
sfc-gh-tzhang
commented
- Improve SDK local setup documentation to enable logging
- Move the storageManager creation into the try-catch block so that the http client will be cleaned in case of exceptions
sfc-gh-tzhang
commented
Jan 24, 2025
Comment on lines
+144
to
+147
| console log output. For changing the logging level or message format, updating the system property or a | ||
| simplelogger.properties file on the classpath is required, please | ||
| see https://www.slf4j.org/api/org/slf4j/simple/SimpleLogger.html for more details. If you run into formatting errors, | ||
| please run format.sh to format the code. |
There was a problem hiding this comment.
This is the major changes, all other changes in this file are done by the auto formatter
Comment on lines
+68
to
+69
| into its own jar, | ||
| whereas the unshaded version declares its dependencies in `pom.xml`, which are fetched as standard transitive |
There was a problem hiding this comment.
Nit, I think these lines should be combined.
There was a problem hiding this comment.
they're combined, you can do "View File" and it will show you a better version
Comment on lines
+110
to
+115
| create | ||
| or replace database MY_DATABASE; | ||
| create | ||
| or replace schema MY_SCHEMA; | ||
| create | ||
| or replace table MY_TABLE(c1 number); |
There was a problem hiding this comment.
The formatting here seems wrong
There was a problem hiding this comment.
this is weird, let me see why auto formatter decided to do this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.