-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1825482: PAT + OAuth Authorization Code + OAuth Client Credentials support #1978
base: master
Are you sure you want to change the base?
Conversation
119a205
to
195ff36
Compare
ec6effb
to
a3dad01
Compare
…bc into oauth-code-flow
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
...main/java/net/snowflake/client/core/auth/oauth/AuthorizationCodeFlowAccessTokenProvider.java
Outdated
Show resolved
Hide resolved
...main/java/net/snowflake/client/core/auth/oauth/AuthorizationCodeFlowAccessTokenProvider.java
Outdated
Show resolved
Hide resolved
...main/java/net/snowflake/client/core/auth/oauth/AuthorizationCodeFlowAccessTokenProvider.java
Outdated
Show resolved
Hide resolved
...main/java/net/snowflake/client/core/auth/oauth/AuthorizationCodeFlowAccessTokenProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/core/auth/oauth/TokenResponseDTO.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me in general, I will need a second look once I get some more knowledge about OAuth
src/test/resources/oauth/authorization_code/successful_scenario_mapping.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't review the whole PR, I just wanted to opine on a couple points I learned about indirectly 🙂
...ain/java/net/snowflake/client/core/auth/oauth/OAuthAuthorizationCodeAccessTokenProvider.java
Outdated
Show resolved
Hide resolved
...ain/java/net/snowflake/client/core/auth/oauth/OAuthAuthorizationCodeAccessTokenProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/core/auth/oauth/OAuthAccessTokenProviderFactory.java
Outdated
Show resolved
Hide resolved
...ain/java/net/snowflake/client/core/auth/oauth/OAuthAuthorizationCodeAccessTokenProvider.java
Show resolved
Hide resolved
...ain/java/net/snowflake/client/core/auth/oauth/OAuthAuthorizationCodeAccessTokenProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/core/auth/oauth/OAuthUtil.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/client/core/OAuthAuthorizationCodeFlowLatestIT.java
Outdated
Show resolved
Hide resolved
...t/java/net/snowflake/client/core/auth/oauth/AuthorizationCodeRedirectRequestHandlerTest.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/core/CachedCredentialType.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/core/auth/oauth/AuthorizationCodeRedirectRequestHandler.java
Show resolved
Hide resolved
src/main/java/net/snowflake/client/core/auth/oauth/OAuthAccessTokenForRefreshTokenProvider.java
Show resolved
Hide resolved
src/main/java/net/snowflake/client/core/auth/oauth/OAuthAccessTokenProviderFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/core/auth/oauth/RandomStateProvider.java
Outdated
Show resolved
Hide resolved
…bc into oauth-code-flow
Overview
SNOW-1825482: PAT + OAuth Authorization Code + OAuth Client Credentials support
Pre-review self checklist
master
branchmvn -P check-style validate
)mvn verify
and inspecttarget/japicmp/japicmp.html
)SNOW-XXXX:
External contributors - please answer these questions before submitting a pull request. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Issue: #NNNN
Fill out the following pre-review checklist:
@SnowflakeJdbcInternalApi
(note that public/protected methods/fields in classes marked with this annotation are already internal)Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.