SNOW-1844765 Make createArrayOf case-insensitive #2010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectionV1, add unit test
src/test/java/net/snowflake/client/jdbc/SnowflakeConnectionV1Test.java
Outdated
Show resolved
Hide resolved
sfc-gh-dprzybysz
approved these changes
Dec 19, 2024
sfc-gh-pfus
approved these changes
Dec 19, 2024
sfc-gh-pmotacki
approved these changes
Dec 19, 2024
sfc-gh-mkubik
deleted the
SNOW-1844765-make-createArrayOf-case-insensitive
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-1844765
As noticed in #1982 - apache spark may turn the type name lowerCase. This behaviour is incompatible with the current createArrayOf implementation in SnowflakeConnectionV1 since it infers the JDBCType from the exact string type name.
toUpperCasecall toJDBCType.valueOfinvocation to allow passing lower/random case strings as type names.