-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1868467: Add custom headers #2016
Open
bpackter
wants to merge
24
commits into
snowflakedb:master
Choose a base branch
from
bpackter:add-custom-headers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
8f1945e
add headers and support crt
bpackter 3ff20f0
add headers and support crt
bpackter 362be8c
add headers and support crt
bpackter 87c3998
add headers and support crt
bpackter 97d8289
add headers and support crt
bpackter 9ab9407
Merge pull request #1 from bpackter/add-support-headers-crt
bpackter 5e1c842
add artifactregistry-maven-wagon
bpackter 72eabb7
Merge remote-tracking branch 'origin/master'
bpackter c630510
add artifactregistry-maven-wagon
bpackter dda292a
add artifactregistry-maven-wagon
bpackter 11a1927
use file
bpackter eba48e1
use file
bpackter 79230d8
add headers for other APIs
bpackter 41f35b5
remove double
bpackter c82123a
revert
bpackter 6917d58
Merge remote-tracking branch 'origin/master'
bpackter a452407
Add custom header to any request
bpackter 05a6693
Add custom header to any request
bpackter 9a98c89
Update pom.xml
bpackter b95cdb6
Update pom.xml
bpackter edf3ecc
Update pom.xml
bpackter b4b9ab2
Merge branch 'master' into add-custom-headers
bpackter 7328d8e
Update pom.xml
bpackter 47b9986
rename
brachi-wernick File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if the value contains ':' or ';' internally? than the simple split could be not sufficient
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, we need to agree on some separator, since this is map of string string.
what do you suggest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the ';' and ':' may be easy to read but e.g. ';' is used in some headers as a separator inside the fields
maybe we can think about url encoded parameters with '&' and
=
as separators - then we could expect that all property values are encoded separately and also the whole property value is encoded e.g.