Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1903631 Add more explicit error message when username or password is missing id DataSource #2056

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

fabiencelier
Copy link
Contributor

@fabiencelier fabiencelier commented Jan 30, 2025

Overview

SNOW-1903631

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: SNOW-1903631: Unclear error message when no password set in DataSource #2055

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

Simply check the parameter (username and password) before putting them into the ConcurrentHashMap so we get a clearer error message instead of a NullPointerException.

@fabiencelier fabiencelier requested a review from a team as a code owner January 30, 2025 10:02
Copy link

github-actions bot commented Jan 30, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@fabiencelier
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-dprzybysz sfc-gh-dprzybysz mentioned this pull request Feb 4, 2025
@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit f8b89f6 into snowflakedb:master Feb 7, 2025
142 of 143 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2025
@sfc-gh-dprzybysz
Copy link
Collaborator

Thank you @fabiencelier for the contribution

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants