Downgrade JDBC to 3.13.30 (#783)

snowflakedb · Feb 6, 2024 · 85b692c · 85b692c
1 parent 6f1e339
commit 85b692c
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 5 deletions.
diff --git a/pom.xml b/pom.xml
@@ -327,7 +327,7 @@
         <dependency>
             <groupId>net.snowflake</groupId>
             <artifactId>snowflake-jdbc</artifactId>
-            <version>3.14.3</version>
+            <version>3.13.30</version>
         </dependency>
 
         <!-- Ingest SDK for copy staged file into snowflake table -->

diff --git a/pom_confluent.xml b/pom_confluent.xml
@@ -379,7 +379,7 @@
         <dependency>
             <groupId>net.snowflake</groupId>
             <artifactId>snowflake-jdbc</artifactId>
-            <version>3.14.3</version>
+            <version>3.13.30</version>
         </dependency>
 
         <!-- Ingest SDK for copy staged file into snowflake table -->

diff --git a/src/main/java/com/snowflake/kafka/connector/internal/InternalUtils.java b/src/main/java/com/snowflake/kafka/connector/internal/InternalUtils.java
@@ -302,9 +302,10 @@ protected static Properties generateProxyParametersIfRequired(Map<String, String
         proxyProperties.put(SFSessionProperty.PROXY_USER.getPropertyKey(), username);
         proxyProperties.put(SFSessionProperty.PROXY_PASSWORD.getPropertyKey(), password);
       }
+      // TODO: uncomment this when JDBC version is upgraded past 3.13.31
       // There is a change in JDBC version 3.13.31 which causes NPE if this is not added.
       // https://github.com/snowflakedb/snowflake-jdbc/blob/master/src/main/java/net/snowflake/client/jdbc/SnowflakeUtil.java#L614
-      proxyProperties.put(SFSessionProperty.GZIP_DISABLED.getPropertyKey(), "false");
+      // proxyProperties.put(SFSessionProperty.GZIP_DISABLED.getPropertyKey(), "false");
     }
     return proxyProperties;
   }

diff --git a/src/test/java/com/snowflake/kafka/connector/internal/InternalStageIT.java b/src/test/java/com/snowflake/kafka/connector/internal/InternalStageIT.java
@@ -144,8 +144,9 @@ public void testInternalStageWithProxy() throws SnowflakeSQLException {
     proxyProperties.put(SFSessionProperty.PROXY_PORT.getPropertyKey(), "3128");
     proxyProperties.put(SFSessionProperty.PROXY_USER.getPropertyKey(), "admin");
     proxyProperties.put(SFSessionProperty.PROXY_PASSWORD.getPropertyKey(), "test");
+    // TODO: add back when upgrading past 3.13.31
     // required otherwise JDBC version 3.13.31 throws NPE
-    proxyProperties.put(SFSessionProperty.GZIP_DISABLED.getPropertyKey(), "false");
+    // proxyProperties.put(SFSessionProperty.GZIP_DISABLED.getPropertyKey(), "false");
 
     // Create new snowflake connection service
     Map<String, String> config = TestUtils.getConf();

diff --git a/test/perf_test/pom.xml b/test/perf_test/pom.xml
@@ -32,7 +32,7 @@
     <dependency>
       <groupId>net.snowflake</groupId>
       <artifactId>snowflake-jdbc</artifactId>
-      <version>3.13.13</version>
+      <version>3.13.30</version>
     </dependency>
     <dependency>
       <groupId>org.apache.kafka</groupId>