Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EmbedText support #115

Merged
merged 5 commits into from
Sep 9, 2024
Merged

Add EmbedText support #115

merged 5 commits into from
Sep 9, 2024

Conversation

zbloss
Copy link
Contributor

@zbloss zbloss commented Sep 4, 2024

Adds support for both SNOWFLAKE.CORTEX.EMBED_TEXT_768 & SNOWFLAKE.CORTEX.EMBED_TEXT_1024 methods into the cortex python sdk.

add EmbedText1024
@sfc-gh-bprosnitz sfc-gh-bprosnitz self-requested a review September 4, 2024 21:15
Copy link

@sfc-gh-bprosnitz sfc-gh-bprosnitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reaching out with this change. I added a few comments, but the change overall looks good to me

snowflake/cortex/BUILD.bazel Show resolved Hide resolved
snowflake/cortex/_embed_text_1024.py Outdated Show resolved Hide resolved
@zbloss
Copy link
Contributor Author

zbloss commented Sep 6, 2024

@sfc-gh-bprosnitz I appreciate you reviewing this code, I've updated it with your suggestions let me know if there's anything else I should clean up.

Copy link

@sfc-gh-bprosnitz sfc-gh-bprosnitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@zbloss
Copy link
Contributor Author

zbloss commented Sep 9, 2024

Happy to help! Do you know a rough timeline on when this change will be merged and available in the public package?

@sfc-gh-thoyt sfc-gh-thoyt self-requested a review September 9, 2024 16:21
@sfc-gh-thoyt sfc-gh-thoyt merged commit 0bdaf0b into snowflakedb:main Sep 9, 2024
3 checks passed
@zbloss
Copy link
Contributor Author

zbloss commented Sep 9, 2024

@sfc-gh-bprosnitz / @sfc-gh-thoyt do you know when 1.6.2 will be released? These changes are very important for some work I'm doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants