-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EmbedText support #115
Conversation
add EmbedText1024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for reaching out with this change. I added a few comments, but the change overall looks good to me
add embed_text_* to PackageVisibilityTest
@sfc-gh-bprosnitz I appreciate you reviewing this code, I've updated it with your suggestions let me know if there's anything else I should clean up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Happy to help! Do you know a rough timeline on when this change will be merged and available in the public package? |
@sfc-gh-bprosnitz / @sfc-gh-thoyt do you know when 1.6.2 will be released? These changes are very important for some work I'm doing. |
Adds support for both
SNOWFLAKE.CORTEX.EMBED_TEXT_768
&SNOWFLAKE.CORTEX.EMBED_TEXT_1024
methods into the cortex python sdk.