Fix return value of snowflake get_table_names #563
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
We did not open a new issue for this.
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
According to the interface, the method
get_table_names
should return a list of strings. See: https://github.com/sqlalchemy/sqlalchemy/blob/6a87d619d9dfe82a8135f0ab3268bf526ac42383/lib/sqlalchemy/engine/reflection.py#L377-L379The return type was updated last week by #556
We found this issue due to the result
dict_keys
no longer being JSON serializable. We already addressed the issue on our side great-expectations/cloud#601 and would like to contribute this fix back to the community :)