Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return value of snowflake get_table_names #563

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TrangPham
Copy link

@TrangPham TrangPham commented Dec 21, 2024

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

We did not open a new issue for this.

  1. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding new credentials
    • I am adding a new dependency
  2. Please describe how your code solves the related issue.

According to the interface, the method get_table_names should return a list of strings. See: https://github.com/sqlalchemy/sqlalchemy/blob/6a87d619d9dfe82a8135f0ab3268bf526ac42383/lib/sqlalchemy/engine/reflection.py#L377-L379

The return type was updated last week by #556

We found this issue due to the result dict_keys no longer being JSON serializable. We already addressed the issue on our side great-expectations/cloud#601 and would like to contribute this fix back to the community :)

@TrangPham TrangPham requested a review from a team as a code owner December 21, 2024 00:24
Copy link

github-actions bot commented Dec 21, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Update test for get_table_names
@TrangPham
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants