Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1063081 Add test for instrumentation scope name #20

Merged
merged 1 commit into from
Mar 13, 2024
Merged

SNOW-1063081 Add test for instrumentation scope name #20

merged 1 commit into from
Mar 13, 2024

Conversation

sfc-gh-tmonk
Copy link
Collaborator

  • Add assertions for scope name to all tests
  • Add test dedicated to observing correct scope name for root logger and local logger, side by side

@sfc-gh-tmonk sfc-gh-tmonk requested a review from a team as a code owner March 13, 2024 23:09
@sfc-gh-tmonk sfc-gh-tmonk merged commit 51b5692 into main Mar 13, 2024
4 checks passed
@sfc-gh-tmonk sfc-gh-tmonk deleted the tmonk-SNOW-1063081-instrumentation-scope-tests branch March 13, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-alitouka sfc-gh-alitouka sfc-gh-alitouka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-tmonk @sfc-gh-alitouka