-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1646883: remove disable sql simplifier hack #2375
Conversation
session = get_active_session() | ||
sql_simplifier_enabled = session.sql_simplifier_enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sfc-gh-aalam is this fixed https://snowflakecomputing.atlassian.net/browse/SNOW-1646883, what is the problem ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know. It used to raise error for test described in the ticket. Seems to have fixed now so this change is no longer required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also @sfc-gh-nkrishna that code seems again violates the architecture in our Snowpark Pandas, that there should be no direct interact with snowpark dataframe, the right way is to provide a static function inside ordered dataframe for range here, and return an ordered dataframe. Then all rest operations should happen on the ordered dataframe. can we get a refactoring task to refact that part?
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1646883
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.