Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1646883: remove disable sql simplifier hack #2375

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

sfc-gh-aalam
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1646883

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-aalam sfc-gh-aalam added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels Sep 30, 2024
@sfc-gh-aalam
Copy link
Contributor Author

@sfc-gh-aalam sfc-gh-aalam marked this pull request as ready for review September 30, 2024 23:04
@sfc-gh-aalam sfc-gh-aalam requested a review from a team as a code owner September 30, 2024 23:04
@sfc-gh-aalam sfc-gh-aalam changed the title SNOW-1646883: remove disable sql simplifier SNOW-1646883: remove disable sql simplifier hack Sep 30, 2024
session = get_active_session()
sql_simplifier_enabled = session.sql_simplifier_enabled
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. It used to raise error for test described in the ticket. Seems to have fixed now so this change is no longer required

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also @sfc-gh-nkrishna that code seems again violates the architecture in our Snowpark Pandas, that there should be no direct interact with snowpark dataframe, the right way is to provide a static function inside ordered dataframe for range here, and return an ordered dataframe. Then all rest operations should happen on the ordered dataframe. can we get a refactoring task to refact that part?

@sfc-gh-aalam sfc-gh-aalam merged commit e362a14 into main Sep 30, 2024
72 of 77 checks passed
@sfc-gh-aalam sfc-gh-aalam deleted the aalam-SNOW-1646883-range-plan-fix branch September 30, 2024 23:14
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants