SNOW-1787415 Fix dataframe AST various bugs and float/decimal infinity, nan etc support #2580
+2,219
−1,207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at and decimal infinity support. Fix default Window spec resulting in an error. Fix parameter ordering bug in lag and lead functions. Add support for float and decimal infinity, nan, etc special values
sfc-gh-evandenberg
requested review from
sfc-gh-yixie,
sfc-gh-aalam and
sfc-gh-jrose
and removed request for
a team
sfc-gh-evandenberg
changed the title
sfc-gh-vbudati
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SNOW-1787415 Fix dataframe AST bugs related to Window, lag, lead, float and decimal infinity support.
Fix default Window spec resulting in an error.
Fix parameter ordering bug in lag and lead functions.
Add support for float and decimal infinity, nan, etc special values