Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1852428: Remove error print in try/catch #2787

Merged
merged 9 commits into from
Jan 24, 2025
Merged

SNOW-1852428: Remove error print in try/catch #2787

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c12fd1e
Remove error message
sfc-gh-yixie Dec 19, 2024
8318bca
Fix linting
sfc-gh-yixie Dec 19, 2024
88da8c0
Add unit test
sfc-gh-yixie Jan 22, 2025
1dcc268
lint
sfc-gh-jrose Jan 22, 2025
fd09df0
Merge branch 'main' into yixie-SNOW-1852428-remove-error-log-check-pa…
sfc-gh-yixie Jan 22, 2025
0dcfca2
Merge branch 'main' into yixie-SNOW-1852428-remove-error-log-check-pa…
sfc-gh-jrose Jan 23, 2025
4e670f8
Add no cover
sfc-gh-yixie Jan 23, 2025
2e1a9c1
Merge branch 'yixie-SNOW-1852428-remove-error-log-check-pandas' of gi…
sfc-gh-yixie Jan 23, 2025
c8d2ff5
Merge branch 'main' into yixie-SNOW-1852428-remove-error-log-check-pa…
sfc-gh-yixie Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/snowflake/snowpark/_internal/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,8 @@ def _pandas_importer(): # noqa: E302
pandas = importlib.import_module("pandas")
# since we enable relative imports without dots this import gives us an issues when ran from test directory
from pandas import DataFrame # NOQA
except ImportError as e:
_logger.error(f"pandas is not installed {e}")
except ImportError:
pass
return pandas


Expand Down
Loading