-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify Snowflake object name handling in the Snowpark AST #2789
Open
sfc-gh-oplaton
wants to merge
13
commits into
main
Choose a base branch
from
oplaton/snow-1621205-object-name
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+42,593
−54,777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-oplaton
added
NO-CHANGELOG-UPDATES
This pull request does not need to update CHANGELOG.md
NO-PANDAS-CHANGEDOC-UPDATES
This PR does not update Snowpark pandas docs
labels
Dec 19, 2024
The serialized batch was getting large enough to exceed command-line length limits
sfc-gh-oplaton
requested review from
sfc-gh-yuwang,
sfc-gh-aalam and
sfc-gh-jrose
December 21, 2024 01:18
sfc-gh-oplaton
changed the title
Introduce a uniform ObjectName trait for referring to Snowflake objects
Unify Snowflake object name handling in the Snowpark AST
Dec 21, 2024
@@ -239,49 +206,39 @@ body { | |||
fn { | |||
builtin_fn { | |||
name { | |||
fn_name_flat { | |||
name: "col" | |||
name { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it's nested twice -- is this intentional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
NO-CHANGELOG-UPDATES
This pull request does not need to update CHANGELOG.md
NO-PANDAS-CHANGEDOC-UPDATES
This PR does not update Snowpark pandas docs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1621205
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
This is the client-side change corresponding to https://github.com/snowflakedb/snowflake/pull/240557
Unify Snowflake object name handling in the Snowpark AST.
Remove
FnName
andSpTableName
. They both hadFlat
andStructured
variants, but ultimately designate Snowflake object names.Introduce
data SpName
andentity SpNameRef
for referring to Snowflake objects by relative or fully qualified name.Update
FnNameRefExpr
.Use
SpNameRef
in a few places that used to useList[String]
.