Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1865910: fixing minor typos #2792

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

SNOW-1865910: fixing minor typos #2792

wants to merge 1 commit into from

Conversation

sfc-gh-batur
Copy link

@sfc-gh-batur sfc-gh-batur commented Dec 19, 2024 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1865910

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-batur sfc-gh-batur requested review from a team as code owners December 19, 2024 22:00
@github-actions github-actions bot added the local testing Local Testing issues/PRs label Dec 19, 2024
@sfc-gh-batur sfc-gh-batur self-assigned this Dec 19, 2024
@sfc-gh-batur sfc-gh-batur added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Dec 19, 2024
sfc-gh-vbudati
sfc-gh-vbudati approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-vbudati sfc-gh-vbudati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bala!

@sfc-gh-batur sfc-gh-batur enabled auto-merge (squash) December 20, 2024 16:21
sfc-gh-evandenberg
sfc-gh-evandenberg approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-evandenberg sfc-gh-evandenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jrose sfc-gh-jrose sfc-gh-jrose approved these changes

@sfc-gh-vbudati sfc-gh-vbudati sfc-gh-vbudati approved these changes

@sfc-gh-evandenberg sfc-gh-evandenberg sfc-gh-evandenberg approved these changes

Assignees

@sfc-gh-batur sfc-gh-batur

Labels
local testing Local Testing issues/PRs NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-batur @sfc-gh-evandenberg @sfc-gh-vbudati @sfc-gh-jrose