Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1830534: Add decoder logic for the dataframe analytics functions #2803

Conversation

sfc-gh-vbudati
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1830534

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

Added decoder logic for the dataframe analytics functions. I "hardcoded" the col formatter lambda used since this is not necessary in the actual decoder but it helps pass the tests. It should not be hard to refactor out/remove.

@sfc-gh-vbudati sfc-gh-vbudati requested a review from a team as a code owner December 20, 2024 22:36
@sfc-gh-vbudati sfc-gh-vbudati merged commit d31ec43 into vbudati/SNOW-1794510-merge-decoder Dec 21, 2024
22 of 37 checks passed
@sfc-gh-vbudati sfc-gh-vbudati deleted the vbudati/SNOW-1830534-df-analytics-fns branch December 21, 2024 00:07
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants