-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add induceJust #209
Add induceJust #209
Conversation
@Avasil Looks great, many thanks! I've added a few minor comments. |
By the way, we could also add induceJust1 :: Graph (Maybe a) -> Maybe (Graph a) Feel free to ignore this if you don't have enough time. |
@snowleopard Thanks for the review! I implemented Mostly in |
Hmm, I'm not sure what's going on with rewrite rules. @nobrakal Could you please have a look? |
That is really strange, I just ran the test suite, and it compiled normally on my machine (with Speaking of rewrite rules, at first glance, it seems that Ps: I just noticed that the bench suite was broken (again...), I really need to fix this once and for all ! |
I'll try to fix the CI here: #210 |
@Avasil Would you like to be listed in https://github.com/snowleopard/alga/blob/master/AUTHORS.md? If yes, please add yourself to the list. |
@snowleopard Thanks, I added myself! @nobrakal Good idea, I can look into that but I'd rather do it in separate PR |
@Avasil Great! All looks good now. I'll merge once CI passes. |
Fixes #202