-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Parquet reader #373
Add Parquet reader #373
Conversation
I'm running into
when running the |
I don't remember where I got the |
* this class is copied from io.trino.parquet.reader.FileParquetDataSource | ||
* because it is in test scope | ||
*/ | ||
public static class FileParquetDataSource |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in the comment. Instead of introducing test-jar into this repo, once we integrate this connector into trino we can then get rid of this class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, if we add test-jar to this pom and then include this connector to Trino, Trino complains during startup
java.lang.NullPointerException: Cannot invoke "org.sonatype.aether.artifact.Artifact.getGroupId()" because "artifact" is null
at io.airlift.resolver.ArtifactResolver.getArtifactKey(ArtifactResolver.java:243)
at io.airlift.resolver.ArtifactResolver.lambda$resolvePom$0(ArtifactResolver.java:184)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:215)
at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1709)
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:570)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:560)
at java.base/java.util.stream.StreamSpliterators$WrappingSpliterator.forEachRemaining(StreamSpliterators.java:315)
at java.base/java.util.stream.Streams$ConcatSpliterator.forEachRemaining(Streams.java:735)
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:570)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:560)
at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:265)
at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:727)
at io.airlift.resolver.ArtifactResolver.resolvePom(ArtifactResolver.java:185)
at io.trino.server.DevelopmentPluginsProvider.buildClassLoaderFromPom(DevelopmentPluginsProvider.java:101)
at io.trino.server.DevelopmentPluginsProvider.doBuildClassLoader(DevelopmentPluginsProvider.java:88)
at io.trino.server.DevelopmentPluginsProvider.buildClassLoader(DevelopmentPluginsProvider.java:76)
at io.trino.server.DevelopmentPluginsProvider.lambda$loadPlugins$0(DevelopmentPluginsProvider.java:67)
at io.trino.server.PluginManager.loadPlugin(PluginManager.java:161)
at io.trino.server.DevelopmentPluginsProvider.lambda$loadPlugins$1(DevelopmentPluginsProvider.java:67)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:572)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
at io.airlift.concurrent.BoundedExecutor.drainQueue(BoundedExecutor.java:79)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
at java.base/java.lang.Thread.run(Thread.java:1575)
Not sure the exact reason tho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash all commits
src/main/java/org/ebyhr/trino/storage/operator/ParquetPlugin.java
Outdated
Show resolved
Hide resolved
190eb8d
to
5ed038c
Compare
@nineinchnick resolved all comments. Please have another review |
Successor of #91
This PR fixes the aforementioned PR with the latest libraries to streamline integration. The core logic remains unchanged.