Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't retry POST request when it's already sent #495

Open
Yuras opened this issue Nov 7, 2022 · 0 comments
Open

Don't retry POST request when it's already sent #495

Yuras opened this issue Nov 7, 2022 · 0 comments

Comments

@Yuras
Copy link
Collaborator

Yuras commented Nov 7, 2022

The library retries HTTP request when NoResponseDataReceived is thrown. But it's thrown after the entire request is already sent to server, and retrying is not safe since request might already reach the server.

I encountered the issue in the wild. Looks like AWS load balancer closes connection after inactivity (idle timeout cutoff) without sending anything to the client. As a result, if the connection was reused, http-client retries the request. Probably our AWS load balancer is misconfigured, but arguably http-client should not retry is such cases. If it's not possible to fix (e.g. because of backward-compatibility concerns), then consider documenting the behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant