Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document escape rules. #250

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Document escape rules. #250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions http-client/Network/HTTP/Client/Request.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,8 @@ parseUrlThrow =
--
-- 'Request' created by this function won't cause exceptions on non-2XX
-- response status codes.
--
-- The URI string will be escaped, and should not be URI escaped.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely an improvement, thank you! However, what do you think about including a small example of how this works in practice?

--
-- @since 0.4.30
parseRequest :: MonadThrow m => String -> m Request
Expand Down