Handle HTTP 103 Early Hints #523
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snoyberg
approved these changes
Dec 22, 2023
|
I think such an addition can make sense. I think it can also be done in a mostly backwards-compatible way. For this PR, can you add a version bump and changelog entry? |
|
Closing in favor of #524 per discussion there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #521 by handling the 103 Early Hints header specially.
It doesn't quite fix fpco/http-reverse-proxy#44. To make the reverse proxy work properly in the present of 103 Early Hints, I think we need to separate the early hint headers from the normal headers. I don't think that can be done without changing the API. I'm thinking we can add a
responseEarlyHeadersfield to theResponseobject and put them in there instead?