This repository has been archived by the owner on Feb 23, 2022. It is now read-only.
Add GNOME 3.32 icons #410
Open
Add GNOME 3.32 icons #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -668,6 +670,7 @@ remote-desktop.png NoMachine.png | |||
| remote-desktop.png preferences-desktop-remote-desktop.png | |||
| remote-desktop.png remmina.png | |||
| samba.png system-config-samba.png | |||
| ../devices/scanner.png org.gnome.SimpleScan.png | |||
There was a problem hiding this comment.
Simple Scan used Icon=scanner before.
Since scanner.png lives in the devices directory instead of the apps directory using scanner.png directly won't work, I couldn't find any other example like this so I added it with this relative symlink.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading to GNOME 3.32 I noticed a couple of missing icons, seems like the
Iconvalue in their.desktopfile has changed. So I added the missing ones.I ran the
generate-symlinks.shscript after adding them toapps.listand included those changes in this PR as well. It seems like that's the correct way of doing these updates?P.S. when running the
generate-symlinks.shscript from current master it generated icons for GNOME Maps and Builder, seems like the script wasn't run for those changes? I've added them as a separate commit.