Skip to content

Conversation

@fabasoad
Copy link
Contributor

@fabasoad fabasoad commented Jul 1, 2025

Currently, snyk/actions/setup supports only x86_64 binaries installation but there are also arm64 available for downloading. With arch input it is possible to define architecture (in the same way as os) which will download respective binary.

@fabasoad fabasoad requested a review from a team as a code owner July 1, 2025 09:13
@snyk-io
Copy link

snyk-io bot commented Jul 1, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@fabasoad fabasoad changed the title Add "arch" input Add "arch" input in snyk/actions/setup Jul 1, 2025
@dotkas
Copy link
Contributor

dotkas commented Jul 2, 2025

Hey @fabasoad - should we extend this test as well for this one? I think this change needs some proof that it's not blowing up anything. 🤔

@fabasoad
Copy link
Contributor Author

fabasoad commented Jul 5, 2025

@dotkas I've added some tests. Please review.

@fabasoad
Copy link
Contributor Author

@dotkas I've added some changes to fix the tests. Please approve workflows to see if my changes fix the issue.

@dotkas
Copy link
Contributor

dotkas commented Aug 4, 2025

Hi @fabasoad - sorry for the delay. It's been summer holiday season 🌅 I see some tests failing. We've got a pretty big backlog in our team these weeks, so I might be slow to respond. Apologies in advance.

@fabasoad fabasoad requested a review from a team as a code owner August 4, 2025 13:48
@fabasoad
Copy link
Contributor Author

fabasoad commented Aug 4, 2025

Hi @dotkas! No worries. I've fixed tests failure. It should work now. Please approve awaiting workflows and let's see if it helps. Thank you.

@dotkas
Copy link
Contributor

dotkas commented Aug 15, 2025

Hey @fabasoad - thanks for your contributions so far. I agree with this PR, and want to merge it, but I need to stall a bit.

I want to make a "clean slate" in this repo, and get off of master, while at the same time starting doing semantic releases as should be expected. Right now all consumers are pinning to @master or a github SHA.

So I want to get this change in after this is done, to decrease the risk of breaking everybody's pipelines.

@fabasoad
Copy link
Contributor Author

@dotkas Totally makes sense. Looking forward to see semantic releases in this repo 👍

@github-actions
Copy link

Your PR has not had any activity for 30 days. In 2 days I'll close it. Make some activity to remove this.

@github-actions github-actions bot added the Stale label Sep 16, 2025
@github-actions github-actions bot removed the Stale label Sep 17, 2025
@EhudB
Copy link

EhudB commented Oct 11, 2025

@dotkas This is something my team also needs, if it would be possible to see this being merged we would love it.

@github-actions
Copy link

Your PR has not had any activity for 30 days. In 2 days I'll close it. Make some activity to remove this.

@github-actions github-actions bot added the Stale label Nov 11, 2025
@github-actions github-actions bot removed the Stale label Nov 13, 2025
@github-actions
Copy link

Your PR has not had any activity for 30 days. In 2 days I'll close it. Make some activity to remove this.

@github-actions github-actions bot added the Stale label Dec 14, 2025
@github-actions github-actions bot removed the Stale label Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants