-
Notifications
You must be signed in to change notification settings - Fork 194
Add "arch" input in snyk/actions/setup #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
@dotkas I've added some tests. Please review. |
|
@dotkas I've added some changes to fix the tests. Please approve workflows to see if my changes fix the issue. |
|
Hi @fabasoad - sorry for the delay. It's been summer holiday season 🌅 I see some tests failing. We've got a pretty big backlog in our team these weeks, so I might be slow to respond. Apologies in advance. |
|
Hi @dotkas! No worries. I've fixed tests failure. It should work now. Please approve awaiting workflows and let's see if it helps. Thank you. |
|
Hey @fabasoad - thanks for your contributions so far. I agree with this PR, and want to merge it, but I need to stall a bit. I want to make a "clean slate" in this repo, and get off of So I want to get this change in after this is done, to decrease the risk of breaking everybody's pipelines. |
|
@dotkas Totally makes sense. Looking forward to see semantic releases in this repo 👍 |
|
Your PR has not had any activity for 30 days. In 2 days I'll close it. Make some activity to remove this. |
|
@dotkas This is something my team also needs, if it would be possible to see this being merged we would love it. |
|
Your PR has not had any activity for 30 days. In 2 days I'll close it. Make some activity to remove this. |
|
Your PR has not had any activity for 30 days. In 2 days I'll close it. Make some activity to remove this. |
Currently,
snyk/actions/setupsupports onlyx86_64binaries installation but there are alsoarm64available for downloading. Witharchinput it is possible to define architecture (in the same way asos) which will download respective binary.