fix: do not exit code 1 with invalid glibc #6342
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-luong
force-pushed
the
fix/cli-1230_glibcChecker
branch
from
99a68d9 to
4027467
Compare
j-luong
force-pushed
the
fix/cli-1230_glibcChecker
branch
from
4027467 to
7546c5a
Compare
PeterSchafer
reviewed
Dec 4, 2025
| // ValidateGlibcVersion checks if the glibc version is supported and returns an Error Catalog error if it is not. | ||
| // This check only applies to glibc-based Linux systems (amd64, arm64). | ||
| // Optionally accepts a custom GlibcVersion, mainly for testing. | ||
| func ValidateGlibcVersion(opt ...GlibcVersion) error { |
Contributor
There was a problem hiding this comment.
Suggestion: Move the glibc validation logic and constants close to the legacycli workflow, since the requirement comes from there. The logic to return the glibc version can be here.
PeterSchafer
reviewed
Dec 4, 2025
| } | ||
|
|
||
| // detectGlibcVersion attempts to detect the glibc version on Linux systems | ||
| func detectGlibcVersion() (string, error) { |
Contributor
There was a problem hiding this comment.
Suggestion: I think we do have plenty of examples on the structure of the ldd output, maybe we can improve the implementation by using this knowledge and adding tests for the different cases? Adding tests for the extraction logic would require it to be callable with a string though. But this would actually implement IOSP. So probably worth it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
are release-note ready, emphasizing
what was changed, not how.
What does this PR do?
This PR fixes an issue where an unsupported
glibcversion will result in a generic error catalog error and an exit code 1 for some Snyk commands.We will not exit code 2 and provide a more useful
RequirementsNotMeterror catalog error.Where should the reviewer start?
How should this be manually tested?
What's the product update that needs to be communicated to CLI users?