Fix active? and trace_context to properly handle inactive traces #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuel-williams-shopify
force-pushed
the
fix-active-and-trace-context-methods
branch
5 times, most recently
from
067d07c to
62970dd
Compare
- Fix Traces.active? to return false when there is no active trace (previously always returned true even for INVALID spans) - Fix Traces.trace_context to return nil when there is no active trace (previously returned invalid Context objects with zero trace_ids) - Both methods now use OpenTelemetry::Trace::Span::INVALID for proper detection of inactive traces instead of manual trace_id checking - Add test case to ensure trace_context returns nil in clean Fiber context - Resolves issues with Async incorrectly detecting active traces
samuel-williams-shopify
force-pushed
the
fix-active-and-trace-context-methods
branch
from
62970dd to
28e9e50
Compare
samuel-williams-shopify
deleted the
fix-active-and-trace-context-methods
branch
simi
reviewed
Aug 26, 2025
| gem "covered" | ||
| gem "decode" | ||
|
|
||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Traces.active?to return false when there is no active trace (previously always returned true even for INVALID spans).Traces.trace_contextto return nil when there is no active trace (previously returned invalid Context objects with zero trace_ids).OpenTelemetry::Trace::Span::INVALIDfor proper detection of inactive traces instead of manual trace_id checking.trace_contextreturns nil in clean Fiber context.Types of Changes
Contribution