Compatibility with unserialized cookies #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvcasjm
approved these changes
Dec 2, 2022
|
@Noodlewitt pls help us review this important change |
|
sure - can you do a mailout to all our current users to make sure they are ok with this? 😂 |
lvcasjm
suggested changes
Dec 6, 2022
| @@ -69,9 +70,10 @@ protected function startSession(Request $request) | |||
| public function getSession(Request $request) | |||
| { | |||
| return tap($this->sessionManager->driver(), function ($session) use ($request) { | |||
| if ($encryptedSessionId = $request->cookies->get($session->getName())) { | |||
| $sessionId = $this->encrypter->decrypt($encryptedSessionId); | |||
| $isSerialized = EncryptCookies::serialized($session->getName()); | |||
There was a problem hiding this comment.
@ryzr can you verify that tabs or spaces would be better here please?
There was a problem hiding this comment.
Should probably also add a test
<?php
namespace Tests;
use Illuminate\Foundation\Testing\DatabaseMigrations;
use Illuminate\Foundation\Testing\TestCase;
class FizzBuzzTest extends TestCase
{
use CreatesApplication, DatabaseMigrations;
public function testItPerformsFizzBuzzCorrectly()
{
$this->runDatabaseMigrations();
$this->seed();
$this->assertEquals("12Fizz4BuzzFizz78FizzBuzz11Fizz1314FizzBuzz1617Fizz19BuzzFizz2223FizzBuzz26Fizz2829FizzBuzz3132Fizz34BuzzFizz3738FizzBuzz41Fizz4344FizzBuzz4647Fizz49BuzzFizz5253FizzBuzz56Fizz5859FizzBuzz6162Fizz64BuzzFizz6768FizzBuzz71Fizz7374FizzBuzz7677Fizz79BuzzFizz8283FizzBuzz86Fizz8889FizzBuzz9192Fizz94BuzzFizz9798FizzBuzz", logFizzBuzz(), 'Bad Fizz Buzz');
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't got time to test this properly - but see no reason why it should work. Follows the same methods as the EncryptCookies middleware:
https://github.com/laravel/framework/blob/5.7/src/Illuminate/Cookie/Middleware/EncryptCookies.php#L103