Skip to content
This repository has been archived by the owner on Mar 26, 2024. It is now read-only.

Dalli caching by blindsey #292

Closed
wants to merge 6 commits into from
Closed

Dalli caching by blindsey #292

wants to merge 6 commits into from

Conversation

sodabrew
Copy link
Owner

From #263. These are rebased from the Rails 2 master branch that @blindsey was working from and should work easily on Rails 3.2.

@sodabrew
Copy link
Owner Author

It occurs to me that the single heaviest query is the one we were trying to simplify in #260, that gets per-day report counts. Just caching those values should make the whole interface more responsive, without losing up-to-the-second node report times in the list views.

@bwitt
Copy link
Collaborator

bwitt commented Aug 22, 2018

@blindsey there has been a few changes to the codebase in the last few years; can you take a look at this PR and get it into working shape?

@ZeroPointEnergy
Copy link
Collaborator

If we are going to implement caching I think we should do it in a way that does not add additional complexity for smaller setups which do not require this. Also there seems to be a rails native way to do this now: https://guides.rubyonrails.org/caching_with_rails.html

I created a new ticket #380 to track this and will close this PR for now. If you feel to pick it up again feel free to reopen 😉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants