Add optimize/orphaned for postgresql database & append many modification for debian #333
Conversation
|
Thank you! I started with some review comments, I'll continue reviewing this soon. |
| gem 'shoulda-matchers', '< 2.0' # support ruby 1.8.7 | ||
| gem 'rspec-html-matchers' | ||
| gem 'nokogiri', '< 1.6' # support ruby 1.8.7 | ||
| gem :developpement, :test do |
There was a problem hiding this comment.
development on this side of the channel / pond ;)
(fixing this to match the original Gemfile should fix the unit tests on Travis)
There was a problem hiding this comment.
french word... I'll change the line
2015-09-16 10:02 GMT+02:00 Aaron Stone [email protected]:
In Gemfile
#333 (comment)
:@@ -28,14 +28,14 @@ group :assets do
gem 'execjs' , '~> 2.0.0' # Will use system-available JS runtime
end-group :development, :test do
- gem 'mocha', '~> 0.13.3', :require => false
- gem 'sqlite3'
- gem 'rspec-rails', '~> 2.13.0'
- gem 'factory_girl', '< 3.0' # supports ruby 1.8.7
- gem 'shoulda-matchers', '< 2.0' # support ruby 1.8.7
- gem 'rspec-html-matchers'
- gem 'nokogiri', '< 1.6' # support ruby 1.8.7
+gem :developpement, :test dodevelopment on this side of the channel / pond ;)
—
Reply to this email directly or view it on GitHub
https://github.com/sodabrew/puppet-dashboard/pull/333/files#r39602590.
| gem 'shoulda-matchers', '< 2.0' # support ruby 1.8.7 | ||
| gem 'rspec-html-matchers' | ||
| gem 'nokogiri', '< 1.6' # support ruby 1.8.7 | ||
| gem :development, :test do |
There was a problem hiding this comment.
Oh, it's group not gem. Would be best to change this block to exactly match the prior Gemfile contents.
|
@swoopla hi thanks for the contribution! I notice your source repo is gone; if you'd like to keep working on this to get it merged I'd be glad to help! |
|
Hi and thanks @swoopla for your contribution. Since this PR contains a lot of different changes I started to separate them in order to have a better overview of what we are changing. PR #373 contains the first bits about the postgres optimizations. There are still some debian and purge task related changes left to extract. The rest of the rebased branch is here: https://github.com/ZeroPointEnergy/puppet-dashboard/commits/debian_and_optimize_postgres I think we can let this PR open for now until everything is extracted and merged. |
i installed puppet-dashboard on a debian machine with postgresql database.
So i had many modifications.
Regards