Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Athena catalog column name to default #1888

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

bichitra95
Copy link

Related Issue: #1887

While profiling for a table, we are fetching the columns metadata for the table here.
The query that generates for fetching the columns is of follows,

SELECT table_name, column_name, data_type 
FROM information_schema.columns 
WHERE (((table_name LIKE 'junaid_test') AND (lower(column_name) LIKE lower('%')))) 
  AND lower(table_schema) = '<database>' 
  AND lower(table_schema) = '<schema>'
ORDER BY ORDINAL_POSITION

So removed the override method to use the parent method which returns table_catalog instead of table_schema.

@CLAassistant
Copy link

CLAassistant commented Jun 8, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ bichitra95
❌ Divyanshu-Patel
❌ sharma-shreyas
You have signed the CLA already but the status is still pending? Let us recheck it.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@m1n0
Copy link
Contributor

m1n0 commented Nov 3, 2023

Thanks for reporting and fixing this @bichitra95 ! I apologize for the delay, this has slipped our attention for too long. Would you be able to resolve the conflicts please so that we can merge this? 🙏

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@m1n0
Copy link
Contributor

m1n0 commented Jun 17, 2024

hi @bichitra95 , are you pushing old commits to this branch? In any case I see a bunch of unrelated changes in this PR, nothing related to the original PR title, could you elaborate please?

Divyanshu-Patel and others added 2 commits October 11, 2024 17:55
PES-3645 Soda <> Redshift IAM Role profiling
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants