Adding unique constraint on the service name #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #92 +/- ##
===============================================
- Coverage 59.6% 58.83% -0.78%
===============================================
Files 12 12
Lines 854 872 +18
Branches 89 91 +2
===============================================
+ Hits 509 513 +4
- Misses 304 318 +14
Partials 41 41
|
… with python 2.x nd then 3.5, as the name creation is unique avoiding the issue with random string generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: If service is created with an existing name then it should not be allowed. To solve this, we have put a unique constraint on the Service name.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #84Special notes for your reviewer: Tested from UI that when service is created with same name then it throws 400 error and the response is " Instance name should be unique"
Release note: