version 1.5.5 (#158)

* upgrade version to 1.5.5 and fix reconnect bug
sofastack · May 20, 2019 · 124fbf4 · 124fbf4
1 parent 0ad7b46
commit 124fbf4
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 2 deletions.
diff --git a/pom.xml b/pom.xml
@@ -22,7 +22,7 @@
     <modelVersion>4.0.0</modelVersion>
     <groupId>com.alipay.sofa</groupId>
     <artifactId>bolt</artifactId>
-    <version>1.5.4</version>
+    <version>1.5.5</version>
     <packaging>jar</packaging>
 
     <name>${project.groupId}:${project.artifactId}</name>

diff --git a/src/main/java/com/alipay/remoting/rpc/RpcClient.java b/src/main/java/com/alipay/remoting/rpc/RpcClient.java
@@ -809,6 +809,9 @@ public boolean checkConnection(String addr) {
      */
     public void closeConnection(String addr) {
         Url url = this.addressParser.parse(addr);
+        if (switches().isOn(GlobalSwitch.CONN_RECONNECT_SWITCH) && reconnectManager != null) {
+            reconnectManager.addCancelUrl(url);
+        }
         this.connectionManager.remove(url.getUniqueKey());
     }
 
@@ -818,6 +821,9 @@ public void closeConnection(String addr) {
      * @param url
      */
     public void closeConnection(Url url) {
+        if (switches().isOn(GlobalSwitch.CONN_RECONNECT_SWITCH) && reconnectManager != null) {
+            reconnectManager.addCancelUrl(url);
+        }
         this.connectionManager.remove(url.getUniqueKey());
     }
 

diff --git a/src/test/java/com/alipay/remoting/rpc/connectionmanage/ReconnectManagerTest.java b/src/test/java/com/alipay/remoting/rpc/connectionmanage/ReconnectManagerTest.java
@@ -105,11 +105,30 @@ public void testReconnectionByUserSetting() throws InterruptedException, Remotin
         Assert.assertEquals(0, clientDisConnectProcessor.getDisConnectTimes());
         Assert.assertEquals(1, clientConnectProcessor.getConnectTimes());
         connection.close();
-        Thread.sleep(1000);
+        Thread.sleep(2000);
         Assert.assertEquals(1, clientDisConnectProcessor.getDisConnectTimes());
         Assert.assertEquals(2, clientConnectProcessor.getConnectTimes());
     }
 
+    @Test
+    public void testCancelReConnection() throws InterruptedException, RemotingException {
+        doInit(false, true);
+        client.enableReconnectSwitch();
+
+        String addr = "127.0.0.1:2014?zone=RZONE&_CONNECTIONNUM=1";
+        Url url = addressParser.parse(addr);
+
+        client.getConnection(url, 1000);
+        Assert.assertEquals(0, clientDisConnectProcessor.getDisConnectTimes());
+        Assert.assertEquals(1, clientConnectProcessor.getConnectTimes());
+
+        client.closeConnection(url);
+
+        Thread.sleep(1000);
+        Assert.assertEquals(1, clientDisConnectProcessor.getDisConnectTimes());
+        Assert.assertEquals(1, clientConnectProcessor.getConnectTimes());
+    }
+
     private void doInit(boolean enableSystem, boolean enableUser) {
         if (enableSystem) {
             System.setProperty(Configs.CONN_RECONNECT_SWITCH, "true");