readme file done #86
Merged
readme file done #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cengique
requested changes
Aug 18, 2024
There was a problem hiding this comment.
here are some small corrections:
- Readme notebook should be open (expanded) by default.
- The button "Go to Readme" should instead just say "More..."
- Readme notebook disappears when you switch to the other tabs (Notebooks, Comments, etc), but it should just stay unless they click "close notebook". I also saw that a new link appears "Go back to Content", but it doesn't work when clicked. If the notebook stays, we won't need this link I assume?
cengique
requested changes
Aug 24, 2024
| }, queryParamsHandling: 'merge' | ||
| }); | ||
| toggleNotebook() { | ||
| // this.router.navigate([this.router.url.split('/').slice(0, 4).join('/') + "/notebook/" + this.readmeNotebook.name], { |
There was a problem hiding this comment.
Maybe add one more button "Edit/Run notebook" that will do this action?
cengique
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.