Skip to content

[DEV-379/BE] fix: 잔여 질답세트에 대해서도 임베딩을 생성하도록 로직 수정 #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kckc0608 merged 2 commits into from
Feb 24, 2026
Merged

[DEV-379/BE] fix: 잔여 질답세트에 대해서도 임베딩을 생성하도록 로직 수정 #609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff4d8e7
fix: 잔여 질답 세트에 대해서도 임베딩을 모두 생성하도록 로직 수정
kckc0608 Feb 24, 2026
25effa7
fix: 임베딩 배치 생성 요청시 요청 개수를 로깅
kckc0608 Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ...n/java/com/shyashyashya/refit/domain/qnaset/event/QuestionBatchEmbeddingEventHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ private List<List<Float>> generateEmbeddings(List<QnaSet> qnaSets) {
for (int i = 0; i < qnaSets.size(); i++) {
sendQnaSets.add(qnaSets.get(i));
if (sendQnaSets.size() == 100) {
var requests = new GeminiBatchEmbeddingRequest(qnaSets.stream()
var requests = new GeminiBatchEmbeddingRequest(sendQnaSets.stream()
.map(qnaSet -> GeminiBatchEmbeddingRequest.GeminiEmbeddingRequest.of(
qnaSet.getQuestionText(),
GeminiEmbeddingRequest.TaskType.SEMANTIC_SIMILARITY,
Expand All @@ -92,6 +92,15 @@ private List<List<Float>> generateEmbeddings(List<QnaSet> qnaSets) {
}
}

var requests = new GeminiBatchEmbeddingRequest(sendQnaSets.stream()
.map(qnaSet -> GeminiBatchEmbeddingRequest.GeminiEmbeddingRequest.of(
qnaSet.getQuestionText(),
GeminiEmbeddingRequest.TaskType.SEMANTIC_SIMILARITY,
outputDimensionality))
.toList());
embeddings.addAll(geminiClient.sendAsyncBatchEmbeddingRequest(requests).join().embeddings().stream()
.toList());

return embeddings.stream()
.map(GeminiBatchEmbeddingResponse.Embedding::values)
.toList();
Expand Down
3 changes: 3 additions & 0 deletions backend/src/main/java/com/shyashyashya/refit/global/gemini/GeminiClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@ public CompletableFuture<GeminiEmbeddingResponse> sendAsyncEmbeddingRequest(Gemi

public CompletableFuture<GeminiBatchEmbeddingResponse> sendAsyncBatchEmbeddingRequest(
GeminiBatchEmbeddingRequest requestBody) {
log.info(
"[sendAsyncBatchEmbeddingRequest] send generate embedding in batch: request size {}",
requestBody.requests().size());
return webClient
.post()
.uri(EMBEDDING_BATCH_ENDPOINT)
Expand Down
Loading