This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
De-duplicate networks in provisioning request #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So the requirement in these parameters is still that there be at most two unique networks (1 private always, and optional public) and the private network must be first in the list. I'm fine with that if it makes Horizon happy. +1 |
| @@ -287,18 +287,22 @@ def _handle_network(self, payload, client, networks): | |||
| 4) --net-id=<private id> --net-id=<public id> | |||
| """ | |||
|
|
|||
| if len(networks) > 2: | |||
| # De-duplicate requested networks | |||
| nets = [] | |||
There was a problem hiding this comment.
networks and nets seem too similar here, perhaps unique_nets would be more clear.
There was a problem hiding this comment.
OK, let me rename it.
Thanks for all your reviews and inputs, @jimlindeman @briancline .
In some particular cases end user could provide duplicated networks in provisioning request by horizion with softlayer network environment, the change de-duplicate these duplicated network ids and make softlayer provision the server(s) with proper network(s). Signed-off-by: Zhi Yan Liu <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some particular cases end user could provide duplicated networks in
provisioning request by horizion with softlayer network environment, the
change de-duplicate these duplicated network ids and make softlayer
provision the server(s) with proper network(s).
Signed-off-by: Zhi Yan Liu [email protected]