Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Token Pattern to allow alphanumeric #223

Merged
merged 3 commits into from
Dec 3, 2015

Conversation

juwara0
Copy link
Member

@juwara0 juwara0 commented Dec 1, 2015

Closes #6

Review on Reviewable

@notmessenger
Copy link
Collaborator

Reviewed 7 of 7 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


addon/components/sl-translate.js, line 91 [r1] (raw file):
Remove the + after the w


Comments from the review on Reviewable.io

@notmessenger
Copy link
Collaborator

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from the review on Reviewable.io

notmessenger added a commit that referenced this pull request Dec 3, 2015
Improved Token Pattern to allow alphanumeric
@notmessenger notmessenger merged commit e429a26 into softlayer:master Dec 3, 2015
@notmessenger notmessenger added this to the v1.11.0 milestone Dec 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants