TRAF. 1451 add ack broker and remove dingo #16
Conversation
|
|
||
| go reader.Start() | ||
| go middleware.Start() | ||
| go incomingMiddleware.HandleInput() |
There was a problem hiding this comment.
I think there is a misconception here. The idea is that middlewareManager is agnostic. It doesn't know about input/output. Just channgels, so you can use that piece as inputMiddlwareManager or outputMiddlewareManager and both have the ability to process messages as middleware or like async GRPC. Now it is a non-generic piece that has two entrypoints that do two different things and does not generalize.
It'd produce two new env variables:
REQUEST_MIDDLEWARES_SOCKET
REQUEST_GRPC_MIDDLEWARES_SOCKET
RESPONSE_MIDDLEWARES_SOCKET
RESPONSE_GRPC_MIDDLEWARES_SOCKET
That it is just the configuration for the same class in two configured objects.
There was a problem hiding this comment.
I understand the idea of making middleware manager agnostic to input/output communication. But I didn't find a way to make it more generic, since the channels are typed. The communication between Reader and Writer is through Message type channels, while the communication Writer -> Reader is through Ack type channels.
The name incomingMiddleware here is wrong, it might be middlewareManager.
There was a problem hiding this comment.
I think you can use a generic type like interface{}
There was a problem hiding this comment.
Do we have some news about this?
There was a problem hiding this comment.
No, we don't. The task TRAF-1354 was pushed back to the backlog due to new priorities and not enough resources.
This subtask of adding middleware between writer and reader was paused, as does not bring value by itself.
Right now multiple middleware can be attached to homing-pigeon before the output is written; in order to let us transform the input somehow.
This PR is to provide homing-pigeon with an option to stream all ACK/NACK messages to a subscribeable channel.
Also I've removed Dingo since it's causing the build to fail.