-
-
Notifications
You must be signed in to change notification settings - Fork 22
feat: Out with flushing, in with batching #1684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cieplypolar
wants to merge
39
commits into
main
Choose a base branch
from
feat/byeflush
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
23aa1c7
Initial investigation
cieplypolar 760398f
Tests for root internals
cieplypolar 2754105
Merge branch 'main' into feat/byeflush
cieplypolar 95a5a79
More tests
cieplypolar 805e863
Compute pipeline flushes
cieplypolar ce2ccea
Fix examples
cieplypolar bd2ccae
First steps with batch()
cieplypolar b558d63
Tests will be moved to the batch suite
cieplypolar b39c1b3
Batch moved to root
cieplypolar 85f5ff0
Batch implemented with tests
cieplypolar d532d48
Batched examples
cieplypolar d3e5837
Docs
cieplypolar a2bd1c6
Docs 2
cieplypolar 104a757
Merge branch 'main' into feat/byeflush
cieplypolar 7cab850
Review fixes
cieplypolar 3f5c807
Missing tests for read, write
cieplypolar 7fa7cfa
Performance callback does not flush
cieplypolar 4ba5660
Updated docs and tests
cieplypolar 39045ba
Merge branch 'main' into feat/byeflush
cieplypolar c3404e0
Review changes 2
cieplypolar de727ca
Merge branch 'main' into feat/byeflush
cieplypolar 492e8b8
Merge branch 'main' into feat/byeflush
cieplypolar 59db68b
Fix example error
cieplypolar 0adde1f
Merge branch 'main' into feat/byeflush
cieplypolar cad8bea
Review changes 3
cieplypolar 46c4b87
Merge branch 'main' into feat/byeflush
cieplypolar cbd56f0
Add questions
iwoplaza 494a835
Fix query set queueing
cieplypolar e2ed09e
querySet fix
cieplypolar 46933fa
Merge branch 'main' into feat/byeflush
cieplypolar 248bdd6
Merge branch 'main' into feat/byeflush
cieplypolar 2f8db16
fix broken merge
cieplypolar 3497031
nested batching
cieplypolar ce3f458
Merge branch 'main' into feat/byeflush
cieplypolar fbff238
more descriptive error
cieplypolar cdb5347
Update docs
cieplypolar 5fc710f
Merge branch 'main' into feat/byeflush
cieplypolar f5e7f3c
Fix broken merge
cieplypolar c106ba9
Merge branch 'main' into feat/byeflush
cieplypolar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -58,6 +58,4 @@ onFrame(() => { | |
], | ||
vertexCount: 3, | ||
}); | ||
|
||
root.flush(); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -77,6 +77,4 @@ onFrame(() => { | |
], | ||
vertexCount: 3, | ||
}); | ||
|
||
runtime.flush(); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -106,6 +106,4 @@ onFrame(() => { | |
], | ||
vertexCount: 3, | ||
}); | ||
|
||
runtime.flush(); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -115,6 +115,4 @@ onFrame(() => { | |
vertexCount: 3, | ||
instanceCount: triangleAmount, | ||
}); | ||
|
||
runtime.flush(); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -124,6 +124,4 @@ onFrame(() => { | |
vertexCount: 3, | ||
instanceCount: triangleAmount, | ||
}); | ||
|
||
runtime.flush(); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -149,6 +149,4 @@ onFrame(() => { | |
vertexCount: 3, | ||
instanceCount: triangleAmount, | ||
}); | ||
|
||
runtime.flush(); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -159,6 +159,4 @@ onFrame(() => { | |
vertexCount: 3, | ||
instanceCount: triangleAmount, | ||
}); | ||
|
||
runtime.flush(); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -172,6 +172,4 @@ onFrame(() => { | |
vertexCount: 3, | ||
instanceCount: triangleAmount, | ||
}); | ||
|
||
runtime.flush(); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -181,6 +181,4 @@ onFrame(() => { | |
vertexCount: 3, | ||
instanceCount: triangleAmount, | ||
}); | ||
|
||
runtime.flush(); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.