fix: Big int handling #1758
Open
fix: Big int handling #1758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 29, 2025 12:14
|
pkg.pr.new packages benchmark commit |
added 2 commits
September 30, 2025 10:42
There was a problem hiding this comment.
Pull Request Overview
This PR fixes big integer handling for floating-point literals in the TGSL type system. The fix ensures that very large numeric literals (beyond 2^63) are treated as abstract floats rather than integers, eliminating the need for explicit f32 casts.
- Added a check in
numericLiteralToSnippetto handle values exceeding 2^63 as abstract floats - Removed unnecessary f32 casts from floating-point constants like
FLT_MAX
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/typegpu/src/tgsl/generationHelpers.ts | Added logic to treat large numeric literals as abstract floats |
| packages/typegpu-color/src/oklab.ts | Removed unnecessary f32 cast from FLT_MAX constant |
| packages/typegpu/tests/examples/individual/oklab.test.ts | Updated test expectation to match new FLT_MAX format |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
aleksanderkatan
requested review from
iwoplaza,
reczkok,
lursz and
cieplypolar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numbers exceeding 2**63 are now automatically inferred as abstractFloat, since it could not fit in an abstractInt anyway.
Now the following does not warn, and the cast is unnecessary.
const FLT_MAX = f32(3.40282346e38);You could argue that we should cast all numbers exceeding safe integers (~2**53) to floats, and that might be correct. Can you help me decide?