Skip to content

build(deps): bump typescript from 5.8.3 to 5.9.3 #1860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

build(deps): bump typescript from 5.8.3 to 5.9.3 #1860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0b4a07
build(deps): bump typescript from 5.8.3 to 5.9.3
dependabot[bot] Nov 5, 2025
7a8b95a
Always pass ArrayBuffer to writeTexture
Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/typegpu/src/core/texture/texture.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ class TgpuTextureImpl<TProps extends TextureProps>
texture: this[$internal].unwrap(),
mipLevel,
},
source,
'buffer' in source ? source.buffer : source,
{
bytesPerRow: this.#formatInfo.texelSize * mipWidth,
rowsPerImage: mipHeight,
Expand Down
4 changes: 2 additions & 2 deletions packages/typegpu/tests/texture.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ Overload 2 of 2, '(schema: "(Error) Storage texture format 'rgba8snorm' incompat
texture: expect.anything(),
mipLevel: 0,
}),
data,
data.buffer,
expect.objectContaining({
bytesPerRow: 16, // 4 pixels * 4 bytes per pixel
rowsPerImage: 4,
Expand All @@ -503,7 +503,7 @@ Overload 2 of 2, '(schema: "(Error) Storage texture format 'rgba8snorm' incompat

expect(device.mock.queue.writeTexture).toHaveBeenCalledWith(
{ texture: expect.anything(), mipLevel: 2 },
data,
data.buffer,
{ bytesPerRow: 8, rowsPerImage: 2 }, // 2 pixels * 4 bytes per pixel
[2, 2, 1], // Mip level 2 dimensions
);
Expand Down
Loading
Loading