WIP: @typegpu/geometry Simplify variable width lines implementation #1935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deluksic
changed the title
deluksic
force-pushed
the
de/simplify-lines
branch
from
f803a49 to
0426fcd
Compare
deluksic
force-pushed
the
de/simplify-lines
branch
2 times, most recently
from
6f83c01 to
7e1978f
Compare
deluksic
force-pushed
the
de/simplify-lines
branch
2 times, most recently
from
db2258a to
ac64859
Compare
deluksic
force-pushed
the
de/simplify-lines
branch
from
ac64859 to
82cf7f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a complete rewrite of the
lineSegmentVariableWidthutility, switching from 2 triangles per line and max-area triangle joins to 4 triangles per line and fan-out joins. The new approach produces more overdraw, but it is a MUCH simpler approach. We should have a purpose-built line rendering for optimizing triangle counts and sizes.New abilities:
NOTE: I'll need a few more iterations to prettify the code and come up with better names for everything, so don't review yet.