Skip to content

Commit

Permalink
Fix infinite reload (#568)
Browse files Browse the repository at this point in the history
This PR fixes a mistake introduced in #563, the return value of
`selectDevice` should indicate if device was chosen successfully, not if
processes on it are successful otherwise if build fails and the selected
device was set by `trySelectingInitiallDevice` we are getting stuck in
infinite loop.
  • Loading branch information
filip131311 authored Sep 24, 2024
1 parent ac6ed99 commit 19d63d8
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion packages/vscode-extension/src/project/project.ts
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,6 @@ export class Project
if (isSelected && isNewSession) {
this.updateProjectState({ status: "buildError" });
}
return false;
}
return true;
}
Expand Down

0 comments on commit 19d63d8

Please sign in to comment.