Fix wrong logic when deciding to wait for app ready (#102)

This PR fixes a bug when we'd use reverse condition to check whether we
should wait for app ready or not. Now after it is fixed when
shouldWaitForAppReady is true we use the promise that waits for an
event. Otherwise, we use a resolved promise.

packages/vscode-extension/src/project/deviceSession.ts

@@ -42,16 +42,16 @@ export class DeviceSession implements Disposable {
   ) {
     const shouldWaitForAppLaunch = getLaunchConfiguration().preview?.waitForAppLaunch !== false;
     const waitForAppReady = shouldWaitForAppLaunch
-      ? Promise.resolve()
-      : new Promise<void>((res) => {
+      ? new Promise<void>((res) => {
           const listener = (event: string, payload: any) => {
             if (event === "RNIDE_appReady") {
               this.devtools?.removeListener(listener);
               res();
             }
           };
           this.devtools?.addListener(listener);
-        });
+        })
+      : Promise.resolve();
 
     progressCallback(StartupMessage.BootingDevice);
     await this.device.bootDevice();